avantgardnerio commented on code in PR #249:
URL: https://github.com/apache/arrow-ballista/pull/249#discussion_r974601573
##########
dev/build-set-env.sh:
##########
@@ -17,4 +17,4 @@
# specific language governing permissions and limitations
# under the License.
-export BALLISTA_VERSION=$(awk -F'[ ="]+' '$1 == "version" { print $2 }'
ballista/rust/core/Cargo.toml)
Review Comment:
@andygrove When I changed the format of the `toml` file before to not
redundantly specify the version, and you said you thought it broke the build
somehow, is this why?
I think if we let `cargo metadata` do the toml parsing, then any correct
toml syntax will work. `awk` was just pattern matching.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
