avantgardnerio commented on code in PR #249: URL: https://github.com/apache/arrow-ballista/pull/249#discussion_r974869235
########## dev/build-ballista-docker.sh: ########## @@ -19,9 +19,13 @@ set -e +docker build -t ballista-builder --build-arg EXT_UID="$(id -u)" -f dev/docker/ballista-builder.Dockerfile . + +docker run -v $(pwd):/home/builder/workspace ballista-builder + +docker-compose build + . ./dev/build-set-env.sh -docker build -t apache/arrow-ballista-base:$BALLISTA_VERSION -f dev/docker/ballista-base.dockerfile . -docker build --build-arg VERSION=$BALLISTA_VERSION -t apache/arrow-ballista:$BALLISTA_VERSION -f dev/docker/ballista.dockerfile . -docker build --build-arg VERSION=$BALLISTA_VERSION -t apache/arrow-ballista-executor:$BALLISTA_VERSION -f dev/docker/ballista-executor.dockerfile . -docker build --build-arg VERSION=$BALLISTA_VERSION -t apache/arrow-ballista-scheduler:$BALLISTA_VERSION -f dev/docker/ballista-scheduler.dockerfile . -docker build --build-arg VERSION=$BALLISTA_VERSION -t apache/arrow-ballista-benchmarks:$BALLISTA_VERSION -f dev/docker/ballista-benchmarks.dockerfile . \ No newline at end of file +docker tag apache/arrow-ballista-executor "apache/arrow-ballista-executor:$BALLISTA_VERSION" Review Comment: We only need the BALLISTA_VERSION when tagging, not buiding. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
