alamb commented on code in PR #3534:
URL: https://github.com/apache/arrow-datafusion/pull/3534#discussion_r976758698
##########
datafusion/proto/src/to_proto.rs:
##########
@@ -1098,7 +1098,7 @@ impl TryFrom<&ScalarValue> for protobuf::ScalarValue {
})
}
datafusion::scalar::ScalarValue::TimestampMicrosecond(val, tz) => {
- create_proto_scalar(val, PrimitiveScalarType::TimeMicrosecond,
|s| {
Review Comment:
> @alamb do you know any history reason this field still named as
TimeMilliSecond?
I do not know why that field is called `TimeMillisecond` -- it is called
`Millisecond` in the arrow schema so I think we could do the same in
Datafusion: https://docs.rs/arrow/23.0.0/arrow/datatypes/enum.TimeUnit.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
