vibhatha commented on code in PR #14186:
URL: https://github.com/apache/arrow/pull/14186#discussion_r979144149
##########
cpp/src/arrow/engine/substrait/expression_internal.cc:
##########
@@ -82,15 +83,6 @@ Result<SubstraitCall> DecodeScalarFunction(
return std::move(call);
}
-std::string EnumToString(int value, const google::protobuf::EnumDescriptor*
descriptor) {
- const google::protobuf::EnumValueDescriptor* value_desc =
- descriptor->FindValueByNumber(value);
- if (value_desc == nullptr) {
- return "unknown";
- }
- return value_desc->name();
-}
-
Review Comment:
I removed this method from `expression_internal.cc` since this can be a
generic util. And put it to the `util.cc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
