vibhatha commented on code in PR #14186:
URL: https://github.com/apache/arrow/pull/14186#discussion_r979144234
##########
cpp/src/arrow/engine/substrait/serde_test.cc:
##########
@@ -179,7 +179,8 @@ void CheckRoundTripResult(const std::shared_ptr<Schema>
output_schema,
compute::ExecContext& exec_context,
std::shared_ptr<Buffer>& buf,
const std::vector<int>& include_columns = {},
- const ConversionOptions& conversion_options = {}) {
+ const ConversionOptions& conversion_options = {},
+ const compute::SortOptions* sort_options = NULLPTR) {
Review Comment:
the logic here is the same as the glob PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]