zeroshade commented on code in PR #14255:
URL: https://github.com/apache/arrow/pull/14255#discussion_r982521622
##########
go/arrow/compute/internal/exec/utils.go:
##########
@@ -135,6 +135,13 @@ func Min[T constraints.Ordered](a, b T) T {
return b
}
+func Max[T constraints.Ordered](a, b T) T {
Review Comment:
In the cases where I'm using this, I don't need it to be well-behaved for
signed zeros. If i need that behavior then I can cast to `float64` and use
`math.Max()` which will be well-behaved for signed zeros
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
