zeroshade commented on code in PR #14255:
URL: https://github.com/apache/arrow/pull/14255#discussion_r982525111


##########
go/arrow/compute/internal/exec/utils.go:
##########
@@ -172,6 +179,11 @@ func GetDataType[T NumericTypes | bool | string]() 
arrow.DataType {
        return typMap[reflect.TypeOf(z)]
 }
 
+func GetType[T NumericTypes | bool | string]() arrow.Type {

Review Comment:
   I'll add the docstring, it returns the appropriate `arrow.Type` enum value 
given the type used in the generic.
   
   It also doesn't make sense to define this for parametric types or allow 
non-primitive types such as random structs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to