lidavidm commented on code in PR #261: URL: https://github.com/apache/arrow-cookbook/pull/261#discussion_r982751735
########## cpp/source/basic.rst: ########## @@ -41,9 +41,9 @@ tedious: :caption: Checking the status of every function manually :dedent: 2 -The macro :c:macro:`ARROW_RETURN_NOT_OK` will take care of some of this -boilerplate for you. It will run the contained expression and check the resulting -``Status`` or ``Result`` object. If it failed then it will return the failure. +The macros :c:macro:`ARROW_RETURN_NOT_OK` and :c:macro:`ARROW_ASSIGN_OR_RAISE` will take care of some of these +boilerplates for you. They will run the contained expression and check the resulting +``Status`` or ``Result`` object. If they failed then they will return the failure. Review Comment: I think one section is OK, just have the text separate so it's clear what applies to what ########## cpp/source/basic.rst: ########## @@ -41,9 +41,9 @@ tedious: :caption: Checking the status of every function manually :dedent: 2 -The macro :c:macro:`ARROW_RETURN_NOT_OK` will take care of some of this -boilerplate for you. It will run the contained expression and check the resulting -``Status`` or ``Result`` object. If it failed then it will return the failure. +The macros :c:macro:`ARROW_RETURN_NOT_OK` and :c:macro:`ARROW_ASSIGN_OR_RAISE` will take care of some of these +boilerplates for you. They will run the contained expression and check the resulting +``Status`` or ``Result`` object. If they failed then they will return the failure. Review Comment: (And separate code blocks) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
