lidavidm commented on code in PR #261:
URL: https://github.com/apache/arrow-cookbook/pull/261#discussion_r982752465
##########
cpp/code/basic_arrow.cc:
##########
@@ -35,6 +35,11 @@ arrow::Status ReturnNotOkMacro() {
if (!st.ok()) {
return st;
}
+ auto res = builder.Finish();
+ std::shared_ptr<arrow::Array> arr;
+ if (res.ok()) {
+ arr = std::move(res).ValueUnsafe();
+ }
Review Comment:
As much as possible I think we should try to keep each code sample focused
on one thing and one thing only, hence why I'd rather not add it here. And
ideally we'd have code both for this approach as well as for the macro-based
approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
