bkietz commented on a change in pull request #8305:
URL: https://github.com/apache/arrow/pull/8305#discussion_r499859844



##########
File path: python/pyarrow/dataset.py
##########
@@ -694,22 +697,23 @@ def _ensure_write_partitioning(scheme):
     return scheme
 
 
-def write_dataset(data, base_dir, format=None, partitioning=None, schema=None,
-                  filesystem=None, use_threads=True):
+def write_dataset(data, base_dir, basename_template, format=None,

Review comment:
       That sounds fine but I'd like to defer that to a follow up




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to