bkietz commented on a change in pull request #8305:
URL: https://github.com/apache/arrow/pull/8305#discussion_r500287304
##########
File path: cpp/src/arrow/dataset/file_base.h
##########
@@ -128,6 +128,9 @@ class ARROW_DS_EXPORT FileFormat : public
std::enable_shared_from_this<FileForma
/// \brief Return true if fragments of this format can benefit from parallel
scanning.
virtual bool splittable() const { return false; }
+ virtual bool Equals(const FileFormat& other) const = 0;
+ // virtual std::string ToString() const = 0;
Review comment:
Yes, the theory was to provide a more descriptive error message if
ParquetFileWriteOptions were provided to IpcFileFormat::MakeWriter. I'll remove
it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
