tustvold commented on code in PR #2811:
URL: https://github.com/apache/arrow-rs/pull/2811#discussion_r984414659


##########
object_store/src/aws/mod.rs:
##########
@@ -370,6 +374,7 @@ impl AmazonS3Builder {
     /// * AWS_DEFAULT_REGION -> region
     /// * AWS_ENDPOINT -> endpoint
     /// * AWS_SESSION_TOKEN -> token
+    /// * AWS_CONTAINER_CREDENTIALS_RELATIVE_URI -> metadata_endpoint

Review Comment:
   ```suggestion
       /// * AWS_CONTAINER_CREDENTIALS_RELATIVE_URI -> 
<https://docs.aws.amazon.com/AmazonECS/latest/developerguide/task-iam-roles.html>
   ```



##########
object_store/src/aws/mod.rs:
##########
@@ -478,6 +492,16 @@ impl AmazonS3Builder {
         self
     }
 
+    /// Set the [instance metadata 
endpoint](https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/ec2-instance-metadata.html),
+    /// used primarily within AWS EC2.
+    ///
+    /// This defaults to the IPv4 endpoint: 169.254.169.254. One can 
alternatively use the IPv6
+    /// endpoint fd00:ec2::254.

Review Comment:
   ```suggestion
       /// This defaults to the IPv4 endpoint: http://169.254.169.254. One can 
alternatively use the IPv6
       /// endpoint http://fd00:ec2::254.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to