unvalley commented on code in PR #3750:
URL: https://github.com/apache/arrow-datafusion/pull/3750#discussion_r989698337


##########
datafusion/core/src/datasource/listing/url.rs:
##########
@@ -108,7 +109,8 @@ impl ListingTableUrl {
 
     /// Creates a new [`ListingTableUrl`] from a url and optional glob 
expression
     fn new(url: Url, glob: Option<Pattern>) -> Self {
-        let prefix = Path::parse(url.path()).expect("should be URL safe");
+        let decoded_path = 
percent_encoding::percent_decode_str(url.path()).decode_utf8_lossy();

Review Comment:
   the `url.path()`, it is still percent encoded string.
   `percent_decode_str` decodes it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to