tustvold commented on code in PR #3750:
URL: https://github.com/apache/arrow-datafusion/pull/3750#discussion_r990015784
##########
datafusion/core/src/datasource/listing/url.rs:
##########
@@ -246,6 +248,9 @@ mod tests {
let url = ListingTableUrl::parse("file:///foo").unwrap();
let child = Path::parse("/foob/bar").unwrap();
assert!(url.strip_prefix(&child).is_none());
+
+ let url = ListingTableUrl::parse("file:///with
space/foo/bar").unwrap();
Review Comment:
Could we get a test of a non-ASCII character such as a percent encoded emoji
or something
We should also test non-URL safe characters like a percent encoded `?`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
