tustvold commented on code in PR #2846:
URL: https://github.com/apache/arrow-rs/pull/2846#discussion_r990194166
##########
arrow/src/compute/kernels/cast.rs:
##########
@@ -1617,33 +1561,6 @@ fn cast_decimal_to_decimal<const BYTE_WIDTH1: usize,
const BYTE_WIDTH2: usize>(
}
}
-/// Cast an array by changing its array_data type to the desired type
Review Comment:
This function isn't sound, as it basically allows arbitrary transmutation of
ArrayData :sweat_smile:
Tbh this was the major motivator for this PR, whilst unsoundness in internal
APIs is not nearly as bad as in public APIs, it is still something to be
avoided.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
