tustvold commented on code in PR #2846:
URL: https://github.com/apache/arrow-rs/pull/2846#discussion_r990236304
##########
arrow-array/src/array/primitive_array.rs:
##########
@@ -769,11 +769,16 @@ impl<T: ArrowTimestampType> PrimitiveArray<T> {
/// Construct a timestamp array with new timezone
pub fn with_timezone(&self, timezone: String) -> Self {
+ self.with_timezone_opt(Some(timezone))
Review Comment:
I went to add this method as was delighted to find #2347 @viirya had already
added it. Apparently I reviewed it but have no recollection :laughing:
Added an optional variant of it, as for this specific case it makes it
easier to work with
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
