jorisvandenbossche commented on code in PR #14343: URL: https://github.com/apache/arrow/pull/14343#discussion_r991389446
########## python/pyarrow/tests/test_plasma_deprecated.py: ########## @@ -0,0 +1,34 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review Comment: I did that when doing the serialization deprecation, so it is easier to ignore all the warnings with a single line of code in the actual test file (see a bit above at https://github.com/apache/arrow/pull/14343/files#diff-d95d9a313ef902a7d822798924fac8a0d542f80c5e4ffe0c74e71a8b94b17245R35) I think I was assuming that if you put such a filterwarnings mark on the full file, you can't catch those warnings anymore in a specific test (since they are already ignored). But not fully sure that is actually true, so maybe it does work to include those tests in the same file -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
