jorisvandenbossche commented on code in PR #14343:
URL: https://github.com/apache/arrow/pull/14343#discussion_r993068808
##########
python/pyarrow/tests/test_plasma.py:
##########
@@ -1071,3 +1075,20 @@ def test_store_capacity():
with plasma.start_plasma_store(plasma_store_memory=10000) as (name, p):
plasma_client = plasma.connect(name)
assert plasma_client.store_capacity() == 10000
+
+
[email protected]
+def test_plasma_deprecated():
+ import pyarrow.plasma as plasma
+
+ with pytest.warns(DeprecationWarning):
+ plasma_store_ctx = plasma.start_plasma_store(
+ plasma_store_memory=10 ** 8,
+ use_valgrind=os.getenv("PLASMA_VALGRIND") == "1")
+ plasma_store_name, _ = plasma_store_ctx.__enter__()
Review Comment:
For this line: `with plasma_store_ctx as plasma_store_name, _ :`
It might be that you need this as `with plasma_store_ctx as
(plasma_store_name, _) :`, otherwise python might be interpreting what comes
after the comma as a second context manager (first guess without actually
trying it out)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
