maartenbreddels commented on a change in pull request #8271:
URL: https://github.com/apache/arrow/pull/8271#discussion_r500950247
##########
File path: cpp/src/arrow/compute/kernels/scalar_string_benchmark.cc
##########
@@ -66,6 +66,11 @@ static void MatchSubstring(benchmark::State& state) {
UnaryStringBenchmark(state, "match_substring", &options);
}
+static void SplitPattern(benchmark::State& state) {
+ SplitPatternOptions options("abac");
+ UnaryStringBenchmark(state, "split_pattern", &options);
Review comment:
I've changed the pattern to "a", which is more meaningful for a true
benchmark. But I use these as a sanity check if there aren't and major
performance issues after refactoring, so I'd like to keep this in.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
