pitrou commented on pull request #8271: URL: https://github.com/apache/arrow/pull/8271#issuecomment-704890478
> I can imagine that we also want to support binary_split_pattern, so should we have to separate kernel names for this, or keep it split_pattern and implement support for binary in the future? The implementation would be exactly the same, right? I think "split_pattern" is fine. > API docs: I'm not sure the compute.rst docs I added should follow some standard, or if that table can be produce using some tool, I've done it by hand for now. We do it by hand indeed. > Should split_pattern be a binary kernel, where pattern is the second argument? I don't think that would make sense, no. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
