lafiona commented on code in PR #14033:
URL: https://github.com/apache/arrow/pull/14033#discussion_r995154592
##########
dev/archery/archery/docker/tests/test_docker.py:
##########
@@ -252,12 +252,12 @@ def
test_arrow_example_validation_passes(arrow_compose_path):
def test_compose_default_params_and_env(arrow_compose_path):
compose = DockerCompose(arrow_compose_path, params=dict(
UBUNTU='18.04',
- DASK='master'
+ DASK='main'
Review Comment:
Thank you for noticing this and bringing it up!
I attempted to fix this by modifying the install scripts to use Git to
compute the current default branch, however, at the time of running the
scripts, the working directory is not within a git repository.
Since the flag value that is used is not dependent on the actual default
branch name of the Arrow or Pandas repositories, it could be helpful to change
the flag value to `default`, or one of the following:
- `devel`
- `upstream_devel`
If this sounds good to you, I can make this change and also update the
documentation page at:
https://arrow.apache.org/docs/developers/continuous_integration/docker.html#usage
to reflect the new flag value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
