lafiona commented on code in PR #14033:
URL: https://github.com/apache/arrow/pull/14033#discussion_r1001956721
##########
dev/archery/archery/crossbow/core.py:
##########
@@ -546,8 +570,10 @@ def github_overwrite_release_assets(self, tag_name,
target_commitish,
'Unsupported upload method {}'.format(method)
)
- def github_pr(self, title, head=None, base="master", body=None,
+ def github_pr(self, title, head=None, base=None, body=None,
github_token=None, create=False):
+ # Default value for base is the default_branch name()
+ base = self.default_branch_name() if base is None else base
Review Comment:
Thanks for catching this! You're right, since it's a computed property, it
does not need parens. I've removed them!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
