westonpace commented on code in PR #14402:
URL: https://github.com/apache/arrow/pull/14402#discussion_r995153934
##########
cpp/src/arrow/engine/substrait/serde_test.cc:
##########
@@ -504,6 +518,8 @@ TEST(Substrait, SupportedLiterals) {
ASSERT_OK_AND_ASSIGN(auto json, internal::SubstraitToJSON("Type", *buf));
ExpectEq("{\"null\": " + json + "}", MakeNullScalar(type));
}
+
+ ConversionOptions conversion_options;
Review Comment:
Nope, this is just leftover from an earlier iteration where I was testing
nullability outside of `ExpectEq`. Thanks for catching. I've removed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
