westonpace commented on code in PR #14402:
URL: https://github.com/apache/arrow/pull/14402#discussion_r995162119
##########
cpp/src/arrow/engine/substrait/expression_internal.cc:
##########
@@ -295,7 +295,8 @@ Result<compute::Expression> FromProto(const
substrait::Expression& expr,
Result<Datum> FromProto(const substrait::Expression::Literal& lit,
const ExtensionSet& ext_set,
const ConversionOptions& conversion_options) {
- if (lit.nullable()) {
Review Comment:
Also, for a list, the type-nullability applies to the values in the list and
not the lists themselves. Same goes for maps. The key/value nullability is
distinct from whether you can have an entirely null map.
So this just leaves the null case and it is very weird to expect producers
to mark a null literal as non-nullable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
