aucahuasi commented on code in PR #14226:
URL: https://github.com/apache/arrow/pull/14226#discussion_r996944475
##########
cpp/src/parquet/arrow/reader.cc:
##########
@@ -1107,8 +1112,13 @@ class RowGroupGenerator {
if (!reader->properties().pre_buffer()) {
row_group_read = SubmitRead(cpu_executor_, reader, row_group,
column_indices);
} else {
+ reader->parquet_reader()->PreBuffer({row_group}, column_indices_,
+ reader_properties_.io_context(),
+ reader_properties_.cache_options());
auto ready = reader->parquet_reader()->WhenBuffered({row_group},
column_indices);
if (cpu_executor_) ready = cpu_executor_->TransferAlways(ready);
+ // wait for buffering the rowgroup before read it
+ ready.Wait();
Review Comment:
I sent [new
changes](https://github.com/apache/arrow/pull/14226/files#diff-6a73dc8ee650cf7b5b8a51f7d4f9f0197823416155c0de7de400294fea588f11R1115)
to avoid the use of `Future::Wait` (in the main thread) and to run the
prebuffering and read operations together in the same thread context (one after
the other).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
