[GitHub] [arrow] aucahuasi commented on a diff in pull request #14226: ARROW-17599: [C++] Change the way how arrow reads parquet buffered files

[GitBox]

aucahuasi commented on code in PR #14226:
URL: https://github.com/apache/arrow/pull/14226#discussion_r1000971921


##########
cpp/src/parquet/arrow/reader.cc:
##########
@@ -1107,11 +1110,23 @@ class RowGroupGenerator {
     if (!reader->properties().pre_buffer()) {
       row_group_read = SubmitRead(cpu_executor_, reader, row_group, 
column_indices);
     } else {
-      auto ready = reader->parquet_reader()->WhenBuffered({row_group}, 
column_indices);
-      if (cpu_executor_) ready = cpu_executor_->TransferAlways(ready);
+      auto ready = ::arrow::Future<>::MakeFinished();
       row_group_read = ready.Then([=]() -> 
::arrow::Future<RecordBatchGenerator> {
-        return ReadOneRowGroup(cpu_executor_, reader, row_group, 
column_indices);
+        BEGIN_PARQUET_CATCH_EXCEPTIONS
+        reader->parquet_reader()->PreBuffer({row_group}, column_indices_,
+                                            reader_properties_.io_context(),
+                                            
reader_properties_.cache_options());
+        END_PARQUET_CATCH_EXCEPTIONS
+        auto wait_buffer =
+            reader->parquet_reader()->WhenBuffered({row_group}, 
column_indices);
+        wait_buffer.Wait();

Review Comment:
   Thanks David, I'll close this PR in favor of 
https://issues.apache.org/jira/browse/ARROW-18113



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org