arw2019 commented on a change in pull request #8145:
URL: https://github.com/apache/arrow/pull/8145#discussion_r501183248
##########
File path: python/pyarrow/_compute.pyx
##########
@@ -669,3 +669,13 @@ cdef class StrptimeOptions(FunctionOptions):
cdef const CFunctionOptions* get_options(self) except NULL:
return self.strptime_options.get()
+
+cdef class VarianceOptions(FunctionOptions):
+ cdef:
+ unique_ptr[CVarianceOptions] variance_options
Review comment:
In `PartitionNthOptions` we need it because it doesn't have a null
constructor so it can't be allocated on the stack. That's not the case for
`VarianceOptions`, though, so I'll take a look
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
