arw2019 commented on a change in pull request #8145:
URL: https://github.com/apache/arrow/pull/8145#discussion_r501200105
##########
File path: python/pyarrow/_compute.pyx
##########
@@ -669,3 +669,13 @@ cdef class StrptimeOptions(FunctionOptions):
cdef const CFunctionOptions* get_options(self) except NULL:
return self.strptime_options.get()
+
+cdef class VarianceOptions(FunctionOptions):
+ cdef:
+ unique_ptr[CVarianceOptions] variance_options
Review comment:
I've rewritten `VarianceOptions` without `unique_ptr`.
I think that with the other three options classes exposed in this PR
(`SetLookupOptions`, `PartitionNthOptions` and `StrptimeOptions`) it's
necessary to use `unique_ptr` or, alternatively, we would need to define
default constructors
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
