tustvold commented on code in PR #2890:
URL: https://github.com/apache/arrow-rs/pull/2890#discussion_r998569595
##########
parquet/src/encodings/levels.rs:
##########
@@ -38,13 +38,8 @@ pub fn max_buffer_size(
) -> usize {
let bit_width = num_required_bits(max_level as u64);
match encoding {
- Encoding::RLE => {
- RleEncoder::max_buffer_size(bit_width, num_buffered_values)
- + RleEncoder::min_buffer_size(bit_width)
- }
- Encoding::BIT_PACKED => {
- ceil((num_buffered_values * bit_width as usize) as i64, 8) as usize
- }
+ Encoding::RLE => RleEncoder::max_buffer_size(bit_width,
num_buffered_values),
Review Comment:
What other estimated sizes, I think I updated them all?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
