tustvold commented on code in PR #2890:
URL: https://github.com/apache/arrow-rs/pull/2890#discussion_r998572857
##########
parquet/src/arrow/arrow_writer/byte_array.rs:
##########
@@ -487,7 +484,10 @@ impl ColumnValueEncoder for ByteArrayEncoder {
}
fn num_values(&self) -> usize {
- self.num_values
+ match &self.dict_encoder {
Review Comment:
The confusion was that we tracked num_values in two places, that is now gone
so I'm not sure what to write in a comment...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
