alamb commented on a change in pull request #8340:
URL: https://github.com/apache/arrow/pull/8340#discussion_r501246915
##########
File path: rust/datafusion/src/logical_plan/mod.rs
##########
@@ -323,21 +322,19 @@ impl Expr {
///
/// # Errors
///
- /// This function errors when it is impossible to cast the expression to
the target [arrow::datatypes::DataType].
+ /// Currently no errors happen at plan time. If it is impossible
Review comment:
It is interesting that there appear to be no uses (or tests) for this
function -- https://github.com/apache/arrow/search?q=cast_to I found this quite
confusing
@jorgecarleitao what do you think about simply removing the whole thing
entirely?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
