alamb commented on a change in pull request #8340:
URL: https://github.com/apache/arrow/pull/8340#discussion_r501262082
##########
File path: rust/datafusion/src/logical_plan/mod.rs
##########
@@ -323,21 +322,19 @@ impl Expr {
///
/// # Errors
///
- /// This function errors when it is impossible to cast the expression to
the target [arrow::datatypes::DataType].
+ /// Currently no errors happen at plan time. If it is impossible
Review comment:
@jorgecarleitao -- I think this makes sense. I was confused about the
intent of `can_coerce_from` (aka that it is for lossless conversions only).
With this explanation let me go back and give adding dictionary coercion / cast
a second pass (though likely not until tomorrow, Thursday, US Eastern time)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
