andygrove commented on PR #3890: URL: https://github.com/apache/arrow-datafusion/pull/3890#issuecomment-1287067077
Currently, if any rule fails with an `Err` then the optimizer just skips that rule, so the user does not see an error and their query works (but maybe not fully optimized). I think this is the correct behavior for now because we know that there are bugs in some of the rules. I would like to have regression tests to that we don't introduce any new bugs that cause rules to fail. One approach would be to set `datafusion.optimizer.skip_failed_rules=false` in all the tests where that does not cause a test failure, and make sure we have issues filed for tests that would fail with that setting and add a comment to those tests, linking to the issue. Long term I would like the setting to default to false, but we need to fix the bugs first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
