andygrove commented on PR #3890: URL: https://github.com/apache/arrow-datafusion/pull/3890#issuecomment-1293774151
> @andygrove got your point thanks. Please check renewed PR > > So idea is by default tests run with enabled `skip_optimization_errors`, to make them fail instead of warning, one can run tests specyfing the conf explicitly as `cargo test --features "optimizer_failed_rules" ` Hi @comphead. Apologies for the delay in reviewing. I'm not sure that we want to introduce feature flags for this. I was thinking that we could explicitly set `datafusion.optimizer.skip_failed_rules` in tests. The goal would be to eventually set this to false but for some tests we would need to leave it as true for now and then file issues for fixing those tests. Does that make sense? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
