pitrou commented on PR #14351: URL: https://github.com/apache/arrow/pull/14351#issuecomment-1287821476
Thanks for the PR @mapleFU . I haven't looked in detail yet. IMHO The testing approach should be to add reference files in https://github.com/apache/parquet-testing/tree/master/data . Ideally these files should provide the given feature matrix: * correct and incorrect CRCs * v1 and v2 data pages * compressed and uncompressed columns This would probably be spread over two files, one with correct CRCs, one with incorrect CRCs. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
