pitrou commented on PR #14351:
URL: https://github.com/apache/arrow/pull/14351#issuecomment-1287822697

   > I'd like to follow the testing here: 
https://github.com/apache/parquet-mr/blob/master/parquet-hadoop/src/test/java/org/apache/parquet/hadoop/TestDataPageV1Checksums.java
   
   This actually seems more complicated to implement (you have to replicate 
details of the file format in the tests).
   Also, without reference files we wouldn't test that different 
implementations actually agree on the CRC computation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to