tustvold commented on code in PR #2915:
URL: https://github.com/apache/arrow-rs/pull/2915#discussion_r1003624245
##########
arrow-data/src/transform/mod.rs:
##########
@@ -637,6 +637,18 @@ impl<'a> MutableArrayData<'a> {
unsafe { self.data.freeze(self.dictionary).build_unchecked() }
}
+ /// Creates a [ArrayData] from the pushed regions up to this point,
consuming `self`,
+ /// with the provided dictionary values `ArrayData`, without any validation
+ ///
+ /// # Safety
+ ///
+ /// As this doesn't validate the provided dictionary `ArrayData` values,
the input
Review Comment:
I'm not entirely sure this will work as expected, MutableArrayData has some
pretty hard assumptions when it comes to dictionaries - it concatenates the
dictionary arrays, and computes new keys based on this assumption
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
