viirya commented on code in PR #2915:
URL: https://github.com/apache/arrow-rs/pull/2915#discussion_r1003637937
##########
arrow-data/src/transform/mod.rs:
##########
@@ -637,6 +637,18 @@ impl<'a> MutableArrayData<'a> {
unsafe { self.data.freeze(self.dictionary).build_unchecked() }
}
+ /// Creates a [ArrayData] from the pushed regions up to this point,
consuming `self`,
+ /// with the provided dictionary values `ArrayData`, without any validation
+ ///
+ /// # Safety
+ ///
+ /// As this doesn't validate the provided dictionary `ArrayData` values,
the input
Review Comment:
This is for the values of dictionaries. What MutableArrayData does is simply
concatenates the value arrays with another MutableArrayData. The caller must
ensure it provides correct concatenated dictionary value array.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
