alamb commented on code in PR #2909:
URL: https://github.com/apache/arrow-rs/pull/2909#discussion_r1003668915
##########
arrow-array/Cargo.toml:
##########
@@ -49,6 +49,7 @@ arrow-buffer = { version = "25.0.0", path = "../arrow-buffer"
}
arrow-schema = { version = "25.0.0", path = "../arrow-schema" }
arrow-data = { version = "25.0.0", path = "../arrow-data" }
chrono = { version = "0.4", default-features = false, features = ["clock"] }
+chrono-tz = { version = "0.7", optional = true }
Review Comment:
I verified we added an equivalent feature to arrow/Cargo.toml so people can
activate this feature from arrow
##########
arrow-array/src/timezone.rs:
##########
@@ -0,0 +1,325 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+//! Timezone for timestamp arrays
Review Comment:
I think it is worth documenting somewhere what enabling the `chrono-tz`
feature of arrow does (and what the expected behavior differences are when it
is / isn't present)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
