mingmwang commented on code in PR #3969:
URL: https://github.com/apache/arrow-datafusion/pull/3969#discussion_r1006891316
##########
datafusion/physical-expr/src/expressions/case.rs:
##########
@@ -286,6 +290,89 @@ impl PhysicalExpr for CaseExpr {
self.case_when_no_expr(batch)
}
}
+
+ fn children(&self) -> Vec<Arc<dyn PhysicalExpr>> {
+ let mut chileren = vec![];
+ match &self.expr {
+ Some(expr) => chileren.push(expr.clone()),
+ None => chileren.push(Arc::new(NoOp::new())),
+ }
+ self.when_then_expr.iter().for_each(|(cond, value)| {
+ chileren.push(cond.clone());
+ chileren.push(value.clone());
+ });
+
+ match &self.else_expr {
+ Some(expr) => chileren.push(expr.clone()),
+ None => chileren.push(Arc::new(NoOp::new())),
+ }
+ chileren
+ }
+
+ // For physical CaseExpr, we do not allow modifying children size
+ fn with_new_children(
+ self: Arc<Self>,
+ children: Vec<Arc<dyn PhysicalExpr>>,
+ ) -> Result<Arc<dyn PhysicalExpr>> {
+ if children.len() != self.children().len() {
+ Err(DataFusionError::Internal(
+ "CaseExpr: Wrong number of children".to_string(),
+ ))
+ } else {
+ assert_eq!(children.len() % 2, 0);
+ let expr = match
children[0].clone().as_any().downcast_ref::<NoOp>() {
+ Some(_) => None,
+ _ => Some(children[0].clone()),
+ };
+ let else_expr = match children[children.len() - 1]
+ .clone()
+ .as_any()
+ .downcast_ref::<NoOp>()
+ {
+ Some(_) => None,
+ _ => Some(children[children.len() - 1].clone()),
+ };
+
+ let branches = children[1..children.len() - 1].to_vec();
+ let mut when_then_expr: Vec<WhenThen> = vec![];
+ for (prev, next) in branches.into_iter().tuples() {
+ when_then_expr.push((prev, next));
+ }
+ Ok(Arc::new(CaseExpr::try_new(
+ expr,
+ when_then_expr,
+ else_expr,
+ )?))
+ }
+ }
+}
+
+impl PartialEq<dyn Any> for CaseExpr {
+ fn eq(&self, other: &dyn Any) -> bool {
+ down_cast_any_ref(other)
+ .downcast_ref::<Self>()
+ .map(|x| {
+ let expr_eq = match (&self.expr, &x.expr) {
+ (Some(expr1), Some(expr2)) => expr1.eq(expr2),
+ (None, None) => true,
+ _ => false,
Review Comment:
Sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
