emkornfield commented on a change in pull request #8325:
URL: https://github.com/apache/arrow/pull/8325#discussion_r502157792
##########
File path: cpp/src/arrow/flight/client.h
##########
@@ -90,6 +90,8 @@ class ARROW_FLIGHT_EXPORT FlightWriteSizeStatusDetail :
public arrow::StatusDeta
class ARROW_FLIGHT_EXPORT FlightClientOptions {
public:
+ FlightClientOptions();
Review comment:
there shouldn't be two ways of getting the default values. If there
needs to be another constructor that takes credentials, then use the static
factory pattern.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
