jduo commented on a change in pull request #8325:
URL: https://github.com/apache/arrow/pull/8325#discussion_r502241411
##########
File path: cpp/src/arrow/flight/client.h
##########
@@ -90,6 +90,8 @@ class ARROW_FLIGHT_EXPORT FlightWriteSizeStatusDetail :
public arrow::StatusDeta
class ARROW_FLIGHT_EXPORT FlightClientOptions {
public:
+ FlightClientOptions();
Review comment:
The default constructor was already there prior to this patch, it was
just being implicitly defined instead of explicitly. I agree in principle that
the Defaults() method should be used, however the constructor has already been
public and I'm not sure it's worth breaking existing application code.
We're not really consistent about this internally either.
The C++ unit tests make use of both the public constructor and Defaults()
method. The Python wrapper uses the public constructor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
