andygrove commented on code in PR #4050:
URL: https://github.com/apache/arrow-datafusion/pull/4050#discussion_r1010645948
##########
datafusion/core/tests/sql/group_by.rs:
##########
@@ -654,13 +654,13 @@ async fn group_by_dictionary() {
.expect("ran plan correctly");
let expected = vec![
- "+-----+------------------------+",
- "| val | COUNT(DISTINCT t.dict) |",
- "+-----+------------------------+",
- "| 1 | 2 |",
- "| 2 | 2 |",
- "| 4 | 1 |",
- "+-----+------------------------+",
+ "+-------+------------------------+",
Review Comment:
I only fixed this for the `single_distinct_to_groupby` case but it would be
good to fix this consistently for all cases. I will see if I can fix in this
PR, or file a new issue if it not trivial
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
