andygrove commented on code in PR #4050:
URL: https://github.com/apache/arrow-datafusion/pull/4050#discussion_r1010944312
##########
datafusion/core/tests/sql/group_by.rs:
##########
@@ -654,13 +654,13 @@ async fn group_by_dictionary() {
.expect("ran plan correctly");
let expected = vec![
- "+-----+------------------------+",
- "| val | COUNT(DISTINCT t.dict) |",
- "+-----+------------------------+",
- "| 1 | 2 |",
- "| 2 | 2 |",
- "| 4 | 1 |",
- "+-----+------------------------+",
+ "+-------+------------------------+",
Review Comment:
I understand this now. The test above is referencing a column named `t.val`
and the physical plan drops column qualifiers:
```
Expr::Column(c) => {
let idx = input_dfschema.index_of_column(c)?;
Ok(Arc::new(Column::new(&c.name, idx)))
}
```
The updated test is referencing a column with an alias of `t.val,` and the
physical plan uses the alias name, hence the different output.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
