yahoNanJing commented on code in PR #4043: URL: https://github.com/apache/arrow-datafusion/pull/4043#discussion_r1013554279
########## datafusion/physical-expr/src/equivalence.rs: ########## @@ -0,0 +1,256 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use crate::expressions::Column; + +use arrow::datatypes::SchemaRef; + +use std::collections::HashMap; +use std::collections::HashSet; + +/// Equivalence Properties is a vec of EquivalentClass. +#[derive(Debug, Default, Clone)] +pub struct EquivalenceProperties { + classes: Vec<EquivalentClass>, +} + +impl EquivalenceProperties { + pub fn new() -> Self { + EquivalenceProperties { classes: vec![] } + } + + pub fn classes(&self) -> &[EquivalentClass] { + &self.classes + } + + pub fn extend<I: IntoIterator<Item = EquivalentClass>>(&mut self, iter: I) { + self.classes.extend(iter) + } + + /// Add new equal conditions into the EquivalenceProperties, the new equal conditions are usually comming from the + /// equality predicates in Join or Filter + pub fn add_equal_conditions(&mut self, new_conditions: (&Column, &Column)) { + let mut idx1: Option<usize> = None; + let mut idx2: Option<usize> = None; Review Comment: An option is much more correct now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
