avantgardnerio commented on issue #3310:
URL:
https://github.com/apache/arrow-datafusion/issues/3310#issuecomment-1305882710
I meant as a concept in general - not using `""` or `0` or `[]` to mean
`None`. But specifically here I meant
```
pub trait TableProviderFactory: Sync + Send {
/// Create a TableProvider given name and url
fn create(&self, name: &str, url: &str, schema: Option<DfSchemaRef>) ->
Arc<dyn TableProvider>;
}
```
vs
```
pub trait TableProviderFactory: Sync + Send {
/// Create a TableProvider given name and url
///
/// Arguments:
/// schema - the schema if known, otherwise an empty schema object to be
populated later
fn create(&self, name: &str, url: &str, schema: DfSchemaRef) -> Arc<dyn
TableProvider>;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
