emkornfield commented on code in PR #14603:
URL: https://github.com/apache/arrow/pull/14603#discussion_r1020617977
##########
cpp/src/parquet/column_reader.h:
##########
@@ -115,6 +116,17 @@ class PARQUET_EXPORT PageReader {
bool always_compressed = false,
const CryptoContext* ctx = NULLPTR);
+ // @returns: true if the skip callback was successfully set. Returns false
+ // if the callback was not set or not supported.
+ // If supported, NextPage() will use this callback to determine if it should
Review Comment:
if we don't have a failure case here in mind, then lets either make the
method void (YAGNI) if we think there is a possible error, then Status should
be returned. Similar question is does this need to be virtual?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
