emkornfield commented on code in PR #14603:
URL: https://github.com/apache/arrow/pull/14603#discussion_r1026709732
##########
cpp/src/parquet/metadata.h:
##########
@@ -182,6 +182,28 @@ class PARQUET_EXPORT ColumnChunkMetaData {
std::unique_ptr<ColumnChunkMetaDataImpl> impl_;
};
+/// \brief DataPageStats is a proxy around stats in format::PageHeader.
+class PARQUET_EXPORT DataPageStats {
+ public:
+ static std::unique_ptr<DataPageStats> Make(const void* page_header);
+
+ ~DataPageStats();
+
+ bool Equals(const DataPageStats& other) const;
+
+ int32_t num_values() const;
Review Comment:
I have a slightly preference for composing encoded stats into this new
object, rather than refactoring. Do you have a preference?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
