tustvold commented on code in PR #3101:
URL: https://github.com/apache/arrow-rs/pull/3101#discussion_r1022084444
##########
arrow-cast/src/parse.rs:
##########
@@ -199,10 +199,123 @@ impl Parser for TimestampSecondType {
}
}
-parser_primitive!(Time64NanosecondType);
-parser_primitive!(Time64MicrosecondType);
-parser_primitive!(Time32MillisecondType);
-parser_primitive!(Time32SecondType);
+impl Parser for Time64NanosecondType {
+ fn parse(string: &str) -> Option<Self::Native> {
Review Comment:
One other option to speed this up might be to do a pass through the string
and compute
* Number of colons
* Presence of space
* Presence of capital `M`
* Presence of decimal point
And use this to prune the list of candidates
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
