Jefffrey commented on code in PR #3101:
URL: https://github.com/apache/arrow-rs/pull/3101#discussion_r1022560318
##########
arrow-cast/src/parse.rs:
##########
@@ -199,10 +199,123 @@ impl Parser for TimestampSecondType {
}
}
-parser_primitive!(Time64NanosecondType);
-parser_primitive!(Time64MicrosecondType);
-parser_primitive!(Time32MillisecondType);
-parser_primitive!(Time32SecondType);
+impl Parser for Time64NanosecondType {
+ fn parse(string: &str) -> Option<Self::Native> {
+ [
+ "%I:%M:%S%.9f %P",
+ "%I:%M:%S%.9f %p",
+ "%l:%M:%S%.9f %P",
+ "%l:%M:%S%.9f %p",
+ "%H:%M:%S%.9f",
Review Comment:
Should no longer be relevant as I've implemented a preprocess pass which
should ensure there isn't a priority clash between 24 and 12 hour time formats
now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
